[
https://issues.apache.org/jira/browse/DRILL-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645658#comment-15645658
]
ASF GitHub Bot commented on DRILL-4935:
---------------------------------------
Github user harrisonmebane commented on a diff in the pull request:
https://github.com/apache/drill/pull/647#discussion_r86883806
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -49,6 +49,7 @@
String USER_RPC_TIMEOUT = "drill.exec.rpc.user.timeout";
String METRICS_CONTEXT_NAME = "drill.exec.metrics.context";
String USE_IP_ADDRESS = "drill.exec.rpc.use.ip";
+ String BIT_ADVERTISED_HOST = "drill.exec.rpc.bit.advertised.host";
--- End diff --
@paul-rogers Thank you for your helpful suggestions. I understand what you
are saying, and indeed, I was using exactly the flow you outlined above for my
own use case.
Let me make sure I understand what you are proposing. We can either:
1. Access the host name as an environment variable, in which case we could
access it via `System.getEnv(...)`
2. Pass the host name in as a system variable
(``-Ddrill.exec.rpc.bit.advertised-host=myhost`), which could just override the
parameter I've already specified in `ExecConstants.java`
In either case, I guess I don't understand why I'd need to add anything to
`drill-env.sh`, unless you mean just to add a commented out line for
documentation purposes. In the second case, is there any change I would need
to make at all?
> Allow drillbits to advertise a configurable host address to Zookeeper
> ---------------------------------------------------------------------
>
> Key: DRILL-4935
> URL: https://issues.apache.org/jira/browse/DRILL-4935
> Project: Apache Drill
> Issue Type: New Feature
> Components: Execution - RPC
> Affects Versions: 1.8.0
> Reporter: Harrison Mebane
> Priority: Minor
> Fix For: Future
>
>
> There are certain situations, such as running Drill in distributed Docker
> containers, in which it is desirable to advertise a different hostname to
> Zookeeper than would be output by INetAddress.getLocalHost(). I propose
> adding a configuration variable 'drill.exec.rpc.bit.advertised.host' and
> passing this address to Zookeeper when the configuration variable is
> populated, otherwise falling back to the present behavior.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
