[ 
https://issues.apache.org/jira/browse/DRILL-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646313#comment-15646313
 ] 

ASF GitHub Bot commented on DRILL-4935:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/647#discussion_r86916748
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -49,6 +49,7 @@
       String USER_RPC_TIMEOUT = "drill.exec.rpc.user.timeout";
       String METRICS_CONTEXT_NAME = "drill.exec.metrics.context";
       String USE_IP_ADDRESS = "drill.exec.rpc.use.ip";
    +  String BIT_ADVERTISED_HOST = "drill.exec.rpc.bit.advertised.host";
    --- End diff --
    
    drill-env.sh is a script that holds the "external" customizations for each 
installation. "External" customizations are those that must be made before 
Drill starts. Setting the memory limit is a typical example. Here, drill-env.sh 
lets you set a value per-node by using a Linux command to set the host name:
    
        export DRILL_HOST_NAME=`hostname`
    
    The idea is that someone who needs your feature would add a line to 
drill-env.sh to set the proper "public" name of the host using a command 
appropriate to their setup. (Maybe using hostname, or, on EC2, using the 
appropriate Amazon-provided command.)
    
    The environment variable would pass the info into Drill where it would 
override the default.
    
    Because the host name must be different per node, and Drill is supposed to 
be distributed, it probably makes a bit less sense to set the host name in the 
Drill config file. (Would be cool if the config file supported scripts - but, 
alas, it does not.)
    
    Similar examples are the DRILL_CONFIG_DIR, DRILL_LOG_DIR, 
DRILL_JAVA_LIB_PATH, etc.


> Allow drillbits to advertise a configurable host address to Zookeeper
> ---------------------------------------------------------------------
>
>                 Key: DRILL-4935
>                 URL: https://issues.apache.org/jira/browse/DRILL-4935
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - RPC
>    Affects Versions: 1.8.0
>            Reporter: Harrison Mebane
>            Priority: Minor
>             Fix For: Future
>
>
> There are certain situations, such as running Drill in distributed Docker 
> containers, in which it is desirable to advertise a different hostname to 
> Zookeeper than would be output by INetAddress.getLocalHost().  I propose 
> adding a configuration variable 'drill.exec.rpc.bit.advertised.host' and 
> passing this address to Zookeeper when the configuration variable is 
> populated, otherwise falling back to the present behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to