[
https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724530#comment-15724530
]
ASF GitHub Bot commented on DRILL-4956:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r91016215
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -523,7 +541,7 @@ public Table getTable(String tableName) {
logger.debug("The filesystem for this workspace does not support
this operation.", e);
}
- return tables.get(tableKey);
+ return tables.get(temporaryTableKey) == null ? tables.get(tableKey)
: tables.get(temporaryTableKey);
--- End diff --
Not a big deal, but requires double lookup.
```
Table t = tables.get(temporaryTableKey);
return t != null ? t : tables.get(tableKey)
```
This function, BTW, cries our for refactoring. But, that is another
project...
> Temporary tables support
> ------------------------
>
> Key: DRILL-4956
> URL: https://issues.apache.org/jira/browse/DRILL-4956
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Arina Ielchiieva
> Assignee: Paul Rogers
> Labels: doc-impacting
> Fix For: Future
>
>
> Link to design doc -
> https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
