[
https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724507#comment-15724507
]
ASF GitHub Bot commented on DRILL-4956:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r90690504
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/FileSystemCreateTableEntry.java
---
@@ -47,28 +47,33 @@
private FormatPlugin formatPlugin;
private String location;
private final List<String> partitionColumns;
+ private final StorageStrategy storageStrategy;
@JsonCreator
public FileSystemCreateTableEntry(@JsonProperty("storageConfig")
FileSystemConfig storageConfig,
@JsonProperty("formatConfig")
FormatPluginConfig formatConfig,
@JsonProperty("location") String
location,
@JsonProperty("partitionColumn")
List<String> partitionColumns,
+ @JsonProperty("storageStrategy")
StorageStrategy storageStrategy,
--- End diff --
Not sure of the semantics here. If we add a new property, will new
Drillbits work with old ones (that don't serialize the property)? Is this
something we should handle? Or, should we make clear that, when switching to
the version of Drill with this change, ALL Drillbits must be upgraded
simultaneously?
> Temporary tables support
> ------------------------
>
> Key: DRILL-4956
> URL: https://issues.apache.org/jira/browse/DRILL-4956
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Arina Ielchiieva
> Assignee: Paul Rogers
> Labels: doc-impacting
> Fix For: Future
>
>
> Link to design doc -
> https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
