[
https://issues.apache.org/jira/browse/DRILL-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729503#comment-15729503
]
ASF GitHub Bot commented on DRILL-5114:
---------------------------------------
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/683
DRILL-5114: Rationalize use of Logback logging in unit tests
Cleans up the Drill test Logback config files to reduce unnecessary
logging in tests and avoid Logback complaints about missing or
duplicate log config files.
Does not affect production logging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/683.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #683
----
commit bbd5ceb4f1c61bfa844701d18220cbd019e1b700
Author: Paul Rogers <[email protected]>
Date: 2016-12-07T18:33:48Z
DRILL-5114: Rationalize use of Logback logging in unit tests
Cleans up the Drill test Logback config files to reduce unnecessary
logging in tests and avoid Logback complaints about missing or
duplicate log config files.
Does not affect production logging.
----
> Rationalize use of Logback logging in unit tests
> ------------------------------------------------
>
> Key: DRILL-5114
> URL: https://issues.apache.org/jira/browse/DRILL-5114
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Paul Rogers
> Priority: Minor
>
> Drill uses Logback as its logger. The logger is used in several to display
> some test output. Test output is sent to stdout, rather than a log file.
> Since Drill also uses Logback, that same configuration sends much Drill
> logging output to stdout as well, cluttering test output.
> Logback requires that that one Logback config file (either logback.xml or
> hogback-test.xml) exist on the class path. Tests store the config file in the
> src/test/resources folder of each sub-project.
> These files set the default logging level to debug. While this setting is
> fine when working with individual tests, the output is overwhelming for bulk
> test runs.
> The first requested change is to set the default logging level to error.
> The existing config files are usually called "logback.xml." Change the name
> of test files to "logback-test.xml" to make clear that they are, in fact,
> test configs.
> The {{exec/java-exec/src/test/resources/logback.xml}} config file is a full
> version of Drill's production config file. Replace this with a config
> suitable for testing (that is, the same as other modules.)
> The java-exec project includes a production-like config file in its non-test
> sources: {{exec/java-exec/src/main/resources/logback.xml}}. Remove this as it
> is not needed. (Instead, rely on the one shipped in the distribution
> subsystem, which is the one copied to the Drill distribution.)
> Since Logback complains bitterly (via many log messages) when it cannot find
> a configuration file (and each sub-module must have its own test
> configuration), add missing logging configuration files:
> * exec/memory/base/src/test/resources/logback-test.xml
> * logical/src/test/resources/logback-test.xml
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
