[
https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800060#comment-15800060
]
ASF GitHub Bot commented on DRILL-4956:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94638547
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WriterRecordBatch.java
---
@@ -174,13 +174,23 @@ protected void setupNewSchema() throws IOException {
schema = container.getSchema();
}
+ /** Clean up needs to be performed before closing writer. Partially
written data will be removed. */
private void closeWriter() {
if (recordWriter != null) {
try {
recordWriter.cleanup();
- recordWriter = null;
} catch(IOException ex) {
context.fail(ex);
+ } finally {
+ try {
+ if (!processed) {
--- End diff --
closeWriter() should not be called twice. But, our code is pretty sloppy
during close operations. If this is called twice, processed will still be
false, but recordWriter will be null. Result: NPE. Perhaps change this to:
```
if (recordWriter == null) { return; }
// Other logic here...
```
> Temporary tables support
> ------------------------
>
> Key: DRILL-4956
> URL: https://issues.apache.org/jira/browse/DRILL-4956
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Labels: doc-impacting
> Fix For: Future
>
>
> Link to design doc -
> https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
