[
https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802633#comment-15802633
]
ASF GitHub Bot commented on DRILL-4956:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/666#discussion_r94859288
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java ---
@@ -164,6 +164,8 @@ public void operationComplete(ChannelFuture future)
throws Exception {
}
final ChannelClosedException ex = future.cause() != null ? new
ChannelClosedException(msg, future.cause()) : new ChannelClosedException(msg);
+ // close client connection to drop all temporary tables
+ clientConnection.close();
--- End diff --
Here we assume that the `close()` won't throw an exception. Clearly, it
throws no checked exceptions. But, Drill likes to throw unchecked exceptions.
Do we need to worry about that here? Even if such an exception were to occur;
we'd still want to close the channel below.
> Temporary tables support
> ------------------------
>
> Key: DRILL-4956
> URL: https://issues.apache.org/jira/browse/DRILL-4956
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Labels: doc-impacting
> Fix For: Future
>
>
> Link to design doc -
> https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
