[ 
https://issues.apache.org/jira/browse/DRILL-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802638#comment-15802638
 ] 

ASF GitHub Bot commented on DRILL-4956:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/666#discussion_r94858477
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonRecordWriter.java
 ---
    @@ -82,6 +84,9 @@ public void init(Map<String, String> writerOptions) 
throws IOException {
         Path fileName = new Path(location, prefix + "_" + index + "." + 
extension);
         try {
           stream = fs.create(fileName);
    +      // set storage strategy for folder and file
    +      storageStrategy.applyToFolder(fs, fileName.getParent());
    --- End diff --
    
    Does this handle the case where I ask to create "foo/bar/mumble/myFile" 
where "foo" exists but "bar" and "mumble" are both new? That is, does it set 
permissions on the full set of newly created folders? Should the 
`applyToFolder` also take on the `mkdirs` task so that it can create each 
folder in the path and set permissions on that folder?


> Temporary tables support
> ------------------------
>
>                 Key: DRILL-4956
>                 URL: https://issues.apache.org/jira/browse/DRILL-4956
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>              Labels: doc-impacting
>             Fix For: Future
>
>
> Link to design doc - 
> https://docs.google.com/document/d/1gSRo_w6q2WR5fPx7SsQ5IaVmJXJ6xCOJfYGyqpVOC-g/edit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to