[
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850928#comment-15850928
]
ASF GitHub Bot commented on DRILL-4280:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99256832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java
---
@@ -39,36 +39,33 @@
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(ControllerImpl.class);
private volatile ControlServer server;
- private final ControlMessageHandler handler;
private final BootStrapContext context;
private final ConnectionManagerRegistry connectionRegistry;
- private final boolean allowPortHunting;
private final CustomHandlerRegistry handlerRegistry;
+ private final BitConnectionConfigImpl config;
- public ControllerImpl(BootStrapContext context, ControlMessageHandler
handler, BufferAllocator allocator,
- boolean allowPortHunting) {
- super();
- this.handler = handler;
+ public ControllerImpl(BootStrapContext context, BufferAllocator
allocator, ControlMessageHandler handler) {
this.context = context;
- this.connectionRegistry = new ConnectionManagerRegistry(allocator,
handler, context);
- this.allowPortHunting = allowPortHunting;
+ config = new BitConnectionConfigImpl(allocator, context, handler);
+ this.connectionRegistry = new ConnectionManagerRegistry(config);
this.handlerRegistry = handler.getHandlerRegistry();
}
@Override
- public DrillbitEndpoint start(DrillbitEndpoint partialEndpoint) throws
DrillbitStartupException {
- server = new ControlServer(handler, context, connectionRegistry);
+ public DrillbitEndpoint start(DrillbitEndpoint partialEndpoint, final
boolean allowPortHunting)
+ throws DrillbitStartupException {
--- End diff --
nothing inside the constructor throws **`DrillbitStartupException`**
> Kerberos Authentication
> -----------------------
>
> Key: DRILL-4280
> URL: https://issues.apache.org/jira/browse/DRILL-4280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Keys Botzum
> Assignee: Sudheesh Katkam
> Labels: security
>
> Drill should support Kerberos based authentication from clients. This means
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should
> support inbound Kerberos. For Web this would most likely be SPNEGO while for
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as
> https://issues.apache.org/jira/browse/DRILL-3584
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
