[
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856483#comment-15856483
]
ASF GitHub Bot commented on DRILL-4280:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99885146
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -568,19 +565,13 @@ public void runQuery(QueryType type,
List<PlanFragment> planFragments, UserResul
* Helper method to generate the UserCredentials message from the
properties.
*/
private UserBitShared.UserCredentials getUserCredentials() {
- // If username is not propagated as one of the properties
- String userName = "anonymous";
-
- if (props != null) {
- for (Property property: props.getPropertiesList()) {
- if (property.getKey().equalsIgnoreCase("user") &&
!Strings.isNullOrEmpty(property.getValue())) {
- userName = property.getValue();
- break;
- }
- }
+ String userName = properties.getProperty(DrillProperties.USER);
+ if (Strings.isNullOrEmpty(userName)) {
+ userName = "anonymous"; // if username is not propagated as one of
the properties
--- End diff --
why not getting the system user then?
> Kerberos Authentication
> -----------------------
>
> Key: DRILL-4280
> URL: https://issues.apache.org/jira/browse/DRILL-4280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Keys Botzum
> Assignee: Sudheesh Katkam
> Labels: security
>
> Drill should support Kerberos based authentication from clients. This means
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should
> support inbound Kerberos. For Web this would most likely be SPNEGO while for
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as
> https://issues.apache.org/jira/browse/DRILL-3584
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)