[ 
https://issues.apache.org/jira/browse/DRILL-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851819#comment-15851819
 ] 

ASF GitHub Bot commented on DRILL-5190:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/738#discussion_r99386366
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
 ---
    @@ -77,12 +77,14 @@
        */
       public static String getPrettyDuration(long startTimeMillis, long 
endTimeMillis) {
         long durationInMillis = (startTimeMillis > endTimeMillis ? 
System.currentTimeMillis() : endTimeMillis) - startTimeMillis;
    -    long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
    +    long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
    --- End diff --
    
    This logic more-or-less duplicates that in DRILL-5230. Please pull this 
logic out into a common utility, and adopt a common display format.


> Display planning time for a query in its profile page
> -----------------------------------------------------
>
>                 Key: DRILL-5190
>                 URL: https://issues.apache.org/jira/browse/DRILL-5190
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>              Labels: ready-to-commit
>
> Currently, the Web UI does not display the time spent in planning for a query 
> in its profile page. The estimate needs to be done by seeing how late did the 
> earliest major fragment start. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to