[
https://issues.apache.org/jira/browse/DRILL-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854979#comment-15854979
]
ASF GitHub Bot commented on DRILL-5190:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99712636
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -77,12 +77,14 @@
*/
public static String getPrettyDuration(long startTimeMillis, long
endTimeMillis) {
long durationInMillis = (startTimeMillis > endTimeMillis ?
System.currentTimeMillis() : endTimeMillis) - startTimeMillis;
- long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);
+ long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);
--- End diff --
The cost of initializing an object is trivial. Unless we are in critical
performance code, code clarity and simplicity is more important than a few
object creations. Indeed, in the code below, each time we do a
```
stringA + stringB
```
We create a temporary String object. So, we are already creating a large
collection of objects.
The question is really 1) code repetition (not duplicating the code to
split out fields) and 2) ease-of-use (making it easy to use the duration format
utility.)
Thanks for combining this code into a utility. Once committed, I will
shamelessly reuse the code to replace the hacks I've used for displaying
durations.
> Display planning time for a query in its profile page
> -----------------------------------------------------
>
> Key: DRILL-5190
> URL: https://issues.apache.org/jira/browse/DRILL-5190
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
>
> Currently, the Web UI does not display the time spent in planning for a query
> in its profile page. The estimate needs to be done by seeing how late did the
> earliest major fragment start.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
