[
https://issues.apache.org/jira/browse/DRILL-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873507#comment-15873507
]
ASF GitHub Bot commented on DRILL-5259:
---------------------------------------
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910132
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles getProfilesJSON() {
final List<ProfileInfo> finishedQueries = Lists.newArrayList();
- final Iterator<Map.Entry<String, QueryProfile>> range =
completed.getRange(0, MAX_PROFILES);
+ //Defining #Profiles to load
+ int maxProfilesToLoad;
+ if (MaxProfiles == null) {
+ MaxProfiles =
work.getContext().getConfig().getInt(ExecConstants.HTTP_MAX_PROFILES);
+ }
+
+ String maxProfilesParams =
uriInfo.getQueryParameters().getFirst(MAX_QPROFILES_PARAM);
--- End diff --
Good point and I was originally doing that. But considering that this is
probably going to support a whole lot more parameters in the future, I thought
I'll leave a generic Context annotation, and let the implementation within the
method handle that.
> Allow listing a user-defined number of profiles
> ------------------------------------------------
>
> Key: DRILL-5259
> URL: https://issues.apache.org/jira/browse/DRILL-5259
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Trivial
> Fix For: 1.10.0
>
>
> Currently, the web UI only lists the last 100 profiles.
> This count is currently hard coded. The proposed change would be to create an
> option in drill-override.conf to provide a flexible default value, and also
> an option within the UI (via optional parameter in the path).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
