[
https://issues.apache.org/jira/browse/DRILL-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873512#comment-15873512
]
ASF GitHub Bot commented on DRILL-5259:
---------------------------------------
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910265
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +192,13 @@ public QProfiles(List<ProfileInfo> runningQueries,
List<ProfileInfo> finishedQue
public List<String> getErrors() { return errors; }
}
+ //max Param to cap listing of profiles
+ private static final String MAX_QPROFILES_PARAM = "max";
--- End diff --
It's just a convenient variable name for now, since it preserves the
constant originally there `MAX_PROFILES`
The patch came as a result of this
[exchange](https://www.mail-archive.com/user@drill.apache.org/msg05992.html) on
drill-user list, so I didn't changing it for the patch. If we use pagination,
perhaps then we can.
For now, someone in the community has proposed this, which takes this
further ahead: [DRILL-5068](https://issues.apache.org/jira/browse/DRILL-5068)
> Allow listing a user-defined number of profiles
> ------------------------------------------------
>
> Key: DRILL-5259
> URL: https://issues.apache.org/jira/browse/DRILL-5259
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Trivial
> Fix For: 1.10.0
>
>
> Currently, the web UI only lists the last 100 profiles.
> This count is currently hard coded. The proposed change would be to create an
> option in drill-override.conf to provide a flexible default value, and also
> an option within the UI (via optional parameter in the path).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
