[
https://issues.apache.org/jira/browse/DRILL-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881161#comment-15881161
]
ASF GitHub Bot commented on DRILL-5195:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102805888
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java
---
@@ -136,25 +215,25 @@ public String getContent() {
biggestBatches = Math.max(biggestBatches, batches);
}
- builder.appendCell(new
OperatorPathBuilder().setMajor(major).setMinor(minor).build(), null);
- builder.appendCell(minor.getEndpoint().getAddress(), null);
- builder.appendMillis(minor.getStartTime() - start, null);
- builder.appendMillis(minor.getEndTime() - start, null);
- builder.appendMillis(minor.getEndTime() - minor.getStartTime(),
null);
+ builder.appendCell(new
OperatorPathBuilder().setMajor(major).setMinor(minor).build(), null, null);
+ builder.appendCell(minor.getEndpoint().getAddress(), null, null);
+ builder.appendMillis(minor.getStartTime() - start, null, null);
+ builder.appendMillis(minor.getEndTime() - start, null, null);
+ builder.appendMillis(minor.getEndTime() - minor.getStartTime(),
null, null);
- builder.appendFormattedInteger(biggestIncomingRecords, null);
- builder.appendFormattedInteger(biggestBatches, null);
+ builder.appendFormattedInteger(biggestIncomingRecords, null, null);
+ builder.appendFormattedInteger(biggestBatches, null, null);
- builder.appendTime(minor.getLastUpdate(), null);
- builder.appendTime(minor.getLastProgress(), null);
+ builder.appendTime(minor.getLastUpdate(), null, null);
+ builder.appendTime(minor.getLastProgress(), null, null);
- builder.appendBytes(minor.getMaxMemoryUsed(), null);
- builder.appendCell(minor.getState().name(), null);
+ builder.appendBytes(minor.getMaxMemoryUsed(), null, null);
+ builder.appendCell(minor.getState().name(), null, null);
--- End diff --
All these extra ", null" parameters (for tool tip) are a clutter. The clean
way to do this is:
```
void appendTime(long ts) {
appendTime(ts, null, null);
}
void appendTime(long ts, String link) {
appendTime(ts, link, null)
}
void appendTime(long ts, String link, String toolTip) {
... // Do stuff here
}
```
And so on.
Then, the above lines are just:
```
builder.appendBytes(minor.getMaxMemoryUsed())
```
> Publish Operator and MajorFragment Stats in Profile page
> --------------------------------------------------------
>
> Key: DRILL-5195
> URL: https://issues.apache.org/jira/browse/DRILL-5195
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Attachments: dbit_complete.png, dbit_inflight.png, dbit_opOverview.png
>
>
> Currently, we show runtimes for major fragments, and min,max,avg times for
> setup, processing and waiting for various operators.
> It would be worthwhile to have additional stats for the following:
> MajorFragment
> %Busy - % of the active time for all the minor fragments within each major
> fragment that they were busy.
> Operator Profile
> %Busy - % of the active time for all the fragments within each operator
> that they were busy.
> Records - Total number of records propagated out by that operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
