[
https://issues.apache.org/jira/browse/DRILL-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881163#comment-15881163
]
ASF GitHub Bot commented on DRILL-5195:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/756#discussion_r102804544
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -33,62 +33,91 @@
private int w = 0;
private int width;
- public TableBuilder(final String[] columns) {
+ public TableBuilder(final String[] columns, final String[]
columnTooltip) {
sb = new StringBuilder();
width = columns.length;
format.setMaximumFractionDigits(3);
sb.append("<table class=\"table table-bordered text-right\">\n<tr>");
- for (final String cn : columns) {
- sb.append("<th>" + cn + "</th>");
+ for (int i = 0; i < columns.length; i++) {
+ String cn = columns[i];
+ String ctt = "";
+ if (columnTooltip != null) {
+ String tooltip = columnTooltip[i];
+ if (tooltip != null) {
+ ctt = " title=\""+tooltip+"\" style=\"color:#00008B;\"";
+ }
+ }
+ sb.append("<th" + ctt + ">" + cn + "</th>");
}
sb.append("</tr>\n");
}
- public void appendCell(final String s, final String link) {
+ public void appendCell(final String s, final String link, final String
titleText) {
if (w == 0) {
sb.append("<tr>");
}
- sb.append(String.format("<td>%s%s</td>", s, link != null ? link : ""));
+ if (titleText != null && titleText.length() > 0) {
+ sb.append(String.format("<td title=\""+titleText+"\">%s%s</td>", s,
link != null ? link : ""));
+ } else {
+ sb.append(String.format("<td>%s%s</td>", s, link != null ? link :
""));
+ }
if (++w >= width) {
sb.append("</tr>\n");
w = 0;
+ } }
+
+ public void appendCellWithBgColor(final String s, final String link,
final String titleText, final String backgroundColor) {
+ if (w == 0) {
+ sb.append("<tr bgcolor=\""+backgroundColor+"\">");
--- End diff --
This is very old-school. Modern web practice is to define a CSS style, then
reference that here:
```
highlight: { background: #aabbcc; }
...
<tr class="highlight"> ...
```
> Publish Operator and MajorFragment Stats in Profile page
> --------------------------------------------------------
>
> Key: DRILL-5195
> URL: https://issues.apache.org/jira/browse/DRILL-5195
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Attachments: dbit_complete.png, dbit_inflight.png, dbit_opOverview.png
>
>
> Currently, we show runtimes for major fragments, and min,max,avg times for
> setup, processing and waiting for various operators.
> It would be worthwhile to have additional stats for the following:
> MajorFragment
> %Busy - % of the active time for all the minor fragments within each major
> fragment that they were busy.
> Operator Profile
> %Busy - % of the active time for all the fragments within each operator
> that they were busy.
> Records - Total number of records propagated out by that operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
