[
https://issues.apache.org/jira/browse/DRILL-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945645#comment-15945645
]
ASF GitHub Bot commented on DRILL-5378:
---------------------------------------
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/801#discussion_r108493803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -324,9 +328,9 @@ public AggOutcome doWork() {
logger.debug("Received new schema. Batch has {}
records.", incoming.getRecordCount());
}
// newSchema = true;
- this.cleanup();
// TODO: new schema case needs to be handled appropriately
- return AggOutcome.UPDATE_AGGREGATOR;
+ this.cleanup();
+ throw SchemaChangeException.schemChanged("Hash aggregate
does not support schema changes", schema, incoming.getSchema());
--- End diff --
Please correct to the renamed function here and elsewhere.
> Put more information into SchemaChangeException when HashJoin hit
> SchemaChangeException
> ---------------------------------------------------------------------------------------
>
> Key: DRILL-5378
> URL: https://issues.apache.org/jira/browse/DRILL-5378
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Priority: Minor
>
> HashJoin currently does not allow schema change in either build side or probe
> side. When HashJoin hit SchemaChangeException in the middle of execution,
> Drill reports a brief error message about SchemaChangeException, without
> providing any information what schemas are in the incoming batches. That
> makes hard to analyze the error, and understand what's going on.
> It probably makes sense to put the two differing schemas in the error
> message, so that user could get better idea about the schema change.
> Before Drill can provide support for schema change in HashJoin, the detailed
> error message would help user debug error.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
