[
https://issues.apache.org/jira/browse/DRILL-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946148#comment-15946148
]
ASF GitHub Bot commented on DRILL-5378:
---------------------------------------
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/801#discussion_r108559083
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -278,7 +281,7 @@ public void setup(HashAggregate hashAggrConfig,
HashTableConfig htConfig, Fragme
}
@Override
- public AggOutcome doWork() {
+ public AggOutcome doWork() throws SchemaChangeException {
--- End diff --
You are right that Streaming aggregator can not handle schema change
exception currently.
In the current code since Drill's planner put sort operator before
streaming aggregator, if the input has schema change, it would hit schema
change exception in sort operator first, before come to streaming aggregator.
Anyway, I modified the code in StreamingAggregator, in case Drill planner
generate a plan without sort for streaming aggregator.
I also simplified the change, since I realized we do not have to change in
AggTemplate; the detailed error message could be produced in AggBatch.
> Put more information into SchemaChangeException when HashJoin hit
> SchemaChangeException
> ---------------------------------------------------------------------------------------
>
> Key: DRILL-5378
> URL: https://issues.apache.org/jira/browse/DRILL-5378
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Reporter: Jinfeng Ni
> Assignee: Jinfeng Ni
> Priority: Minor
>
> HashJoin currently does not allow schema change in either build side or probe
> side. When HashJoin hit SchemaChangeException in the middle of execution,
> Drill reports a brief error message about SchemaChangeException, without
> providing any information what schemas are in the incoming batches. That
> makes hard to analyze the error, and understand what's going on.
> It probably makes sense to put the two differing schemas in the error
> message, so that user could get better idea about the schema change.
> Before Drill can provide support for schema change in HashJoin, the detailed
> error message would help user debug error.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
