[ 
https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998549#comment-15998549
 ] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r115038181
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java
 ---
    @@ -217,8 +224,9 @@ public SaslMessage process(SaslChallengeContext 
context) throws Exception {
       private static class SaslFailedProcessor implements 
SaslChallengeProcessor {
     
         @Override
    -    public SaslMessage process(SaslChallengeContext context) throws 
Exception {
    -      throw new SaslException("Authentication failed. Incorrect 
credentials?");
    +    public <CC extends ClientConnection> SaslMessage 
process(SaslChallengeContext<CC> context) throws Exception {
    +      throw new SaslException(String.format("Authentication with 
encryption context %s failed. Incorrect credentials?",
    --- End diff --
    
    Fix error message format to match the format in UserClient.


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this 
> needs to include network level encryption and not just authentication. This 
> is particularly important for the client connection to Drill which will often 
> be sending passwords in the clear until there is encryption.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to