[ 
https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998550#comment-15998550
 ] 

ASF GitHub Bot commented on DRILL-4335:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/773#discussion_r115037769
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java
 ---
    @@ -110,7 +131,18 @@ public void changeHandlerTo(final RequestHandler<S> 
handler) {
       }
     
       @Override
    -  public void close() {
    +  public void setEncryption(boolean encrypted) {
    +    throw new UnsupportedOperationException("Changing encryption setting 
on server connection is not permitted.");
    +  }
    +
    +  @Override
    +  public void setMaxWrappedSize(int maxWrappedChunkSize) {
    --- End diff --
    
    maxWrappedChunkSize -> maxWrappedSize; in argument and message


> Apache Drill should support network encryption
> ----------------------------------------------
>
>                 Key: DRILL-4335
>                 URL: https://issues.apache.org/jira/browse/DRILL-4335
>             Project: Apache Drill
>          Issue Type: New Feature
>            Reporter: Keys Botzum
>            Assignee: Sorabh Hamirwasia
>              Labels: security
>         Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this 
> needs to include network level encryption and not just authentication. This 
> is particularly important for the client connection to Drill which will often 
> be sending passwords in the clear until there is encryption.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to