[
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151133#comment-16151133
]
ASF GitHub Bot commented on DRILL-5723:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r136658551
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/OptionIterator.java
---
@@ -36,7 +36,7 @@
// private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(OptionIterator.class);
enum Mode {
- BOOT, SYS_SESS, BOTH
+ BOOT, SYS_SESS_EXTERNAL, SYS_SESS_INTERNAL, BOTH
--- End diff --
Can we improve these names? Maybe `RUNTIME` for system/session option.
I'm not clear on the distinction between external and internal. Do we mean
something like public and internal?
Does the external mean only public, while internal means public and private?
And, given that we have three options, `BOTH` seems a bit of a misnomer...
> Support System/Session Internal Options
> ---------------------------------------
>
> Key: DRILL-5723
> URL: https://issues.apache.org/jira/browse/DRILL-5723
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would
> like to add internal options which can be altered, but are not visible in the
> sys.options table. These internal options could be seen by another alias
> select * from internal.options. The intention would be to put new options we
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they
> could be changed to appear in the sys.option table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
