[
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151134#comment-16151134
]
ASF GitHub Bot commented on DRILL-5723:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r136660399
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -83,18 +86,20 @@
@VisibleForTesting
public Drillbit(
final DrillConfig config,
+ final CaseInsensitiveMap<OptionValidator> validators,
final RemoteServiceSet serviceSet) throws Exception {
- this(config, serviceSet, ClassPathScanner.fromPrescan(config));
+ this(config, validators, serviceSet,
ClassPathScanner.fromPrescan(config));
--- End diff --
Interesting... Why was this change needed?
To be honest, I'm not convinced that the set of inputs is an *input* to the
Drillbit rather than an internal *attribute* of the Drillbit. That is, the
Drillbit should be responsible for defining its set of valid options, not the
code that houses the Drillbit.
> Support System/Session Internal Options
> ---------------------------------------
>
> Key: DRILL-5723
> URL: https://issues.apache.org/jira/browse/DRILL-5723
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would
> like to add internal options which can be altered, but are not visible in the
> sys.options table. These internal options could be seen by another alias
> select * from internal.options. The intention would be to put new options we
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they
> could be changed to appear in the sys.option table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
