[
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160129#comment-16160129
]
ASF GitHub Bot commented on DRILL-5723:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r137937392
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
---
@@ -63,32 +88,32 @@
public final Double float_val;
public final OptionScope scope;
- public static OptionValue createLong(OptionType type, String name, long
val, OptionScope scope) {
+ public static OptionValue create(OptionType type, String name, long val,
OptionScope scope) {
return new OptionValue(Kind.LONG, type, name, val, null, null, null,
scope);
}
- public static OptionValue createBoolean(OptionType type, String name,
boolean bool, OptionScope scope) {
+ public static OptionValue create(OptionType type, String name, boolean
bool, OptionScope scope) {
return new OptionValue(Kind.BOOLEAN, type, name, null, null, bool,
null, scope);
}
- public static OptionValue createString(OptionType type, String name,
String val, OptionScope scope) {
+ public static OptionValue create(OptionType type, String name, String
val, OptionScope scope) {
return new OptionValue(Kind.STRING, type, name, null, val, null, null,
scope);
}
- public static OptionValue createDouble(OptionType type, String name,
double val, OptionScope scope) {
+ public static OptionValue create(OptionType type, String name, double
val, OptionScope scope) {
return new OptionValue(Kind.DOUBLE, type, name, null, null, null, val,
scope);
}
- public static OptionValue createOption(Kind kind, OptionType type,
String name, String val, OptionScope scope) {
+ public static OptionValue create(Kind kind, OptionType type, String
name, String val, OptionScope scope) {
--- End diff --
Per earlier comment, `String val` --> `Object val`, with casts rather than
string conversions below?
> Support System/Session Internal Options And Additional Option System Fixes
> --------------------------------------------------------------------------
>
> Key: DRILL-5723
> URL: https://issues.apache.org/jira/browse/DRILL-5723
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would
> like to add internal options which can be altered, but are not visible in the
> sys.options table. These internal options could be seen by another alias
> select * from internal.options. The intention would be to put new options we
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they
> could be changed to appear in the sys.option table.
> A bunch of other fixes to the Option system have been clubbed into this:
> * OptionValidators no longer hold default values. Default values are
> contained in the SystemOptionManager
> * Options have an OptionDefinition. The option definition includes:
> * A validator
> * Metadata about the options visibility, required permissions, and the
> scope in which it can be set.
> * The Option Manager interface has been cleaned up so that a Type is not
> required to be passed in in order to set and delete options
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
