[
https://issues.apache.org/jira/browse/DRILL-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160134#comment-16160134
]
ASF GitHub Bot commented on DRILL-5723:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/923#discussion_r137937210
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/DrillConfigIterator.java
---
@@ -58,17 +58,17 @@ public OptionValue next() {
OptionValue optionValue = null;
switch(cv.valueType()) {
case BOOLEAN:
- optionValue = OptionValue.createBoolean(OptionType.BOOT, name,
(Boolean) cv.unwrapped(), OptionScope.BOOT);
+ optionValue = OptionValue.create(OptionType.BOOT, name, (Boolean)
cv.unwrapped(), OptionScope.BOOT);
--- End diff --
I suppose this has worked, but it is a bit of a muddle. Config settings are
not runtime options. It is a hack to map them into the same structures. Since
this iterator is probably only used to create a table, at some point we
probably should create a new object to handle config options. We might want: 1)
the full name, 2) the source (system options, command line,
drill-override.conf, etc.), 3) the TypeSafe type (which is a superset of the
runtime option types.
OK to leave this for now, but we should consider fixing this in the future.
> Support System/Session Internal Options And Additional Option System Fixes
> --------------------------------------------------------------------------
>
> Key: DRILL-5723
> URL: https://issues.apache.org/jira/browse/DRILL-5723
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> This is a feature proposed by [~ben-zvi].
> Currently all the options are accessible by the user in sys.options. We would
> like to add internal options which can be altered, but are not visible in the
> sys.options table. These internal options could be seen by another alias
> select * from internal.options. The intention would be to put new options we
> weren't comfortable with exposing to the end user in this table.
> After the options and their corresponding features are considered stable they
> could be changed to appear in the sys.option table.
> A bunch of other fixes to the Option system have been clubbed into this:
> * OptionValidators no longer hold default values. Default values are
> contained in the SystemOptionManager
> * Options have an OptionDefinition. The option definition includes:
> * A validator
> * Metadata about the options visibility, required permissions, and the
> scope in which it can be set.
> * The Option Manager interface has been cleaned up so that a Type is not
> required to be passed in in order to set and delete options
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
