[
https://issues.apache.org/jira/browse/DRILL-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191618#comment-16191618
]
ASF GitHub Bot commented on DRILL-5832:
---------------------------------------
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/970
@paul-rogers Some tests are failing on my machine
```
Failed tests:
TestMetadataProvider.tables:154 expected:<OK> but was:<FAILED>
TestMetadataProvider.tablesWithTableNameFilter:219 expected:<OK> but
was:<FAILED>
TestMetadataProvider.tablesWithSystemTableFilter:191 expected:<OK> but
was:<FAILED>
TestMetadataProvider.tablesWithTableFilter:180 expected:<OK> but
was:<FAILED>
Tests in error:
TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR:
URISyn...
TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth »
UserRemote
TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR:
URISyntaxExcepti...
TestViewSupport.infoSchemaWithView:355->BaseTestQuery.testRunAndReturn:356 » Rpc
TestInfoSchemaFilterPushDown.testFilterPushdown_NonEqual » UserRemote
SYSTEM E...
TestParquetScan.testSuccessFile:60->BaseTestQuery.testRunAndReturn:356 »
Rpc o...
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestSchemaChange.org.apache.drill.TestSchemaChange » Rpc CONNECTION :
java.net...
TestSchemaChange>DrillTest.finiDrillTest:106 » Interrupted sleep
interrupted
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestSelectivity.org.apache.drill.TestSelectivity » Rpc CONNECTION :
java.net.N...
TestSelectivity>DrillTest.finiDrillTest:106 » Interrupted sleep
interrupted
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestSelectWithOption.org.apache.drill.TestSelectWithOption » Rpc
CONNECTION : ...
TestSelectWithOption>DrillTest.finiDrillTest:106 » Interrupted sleep
interrupt...
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestDynamicUDFSupport.setup:91->BaseTestQuery.updateTestCluster:148->BaseTestQuery.updateTestCluster:166
» Runtime
TestDynamicUDFSupport>DrillTest.finiDrillTest:106 » Interrupted sleep
interrup...
TestTpchDistributed.tpch14 » User CONNECTION ERROR: Connection
/192.168.0.80:4...
TestTpchDistributed.tpch15:104->testDistributed:28->BaseTestQuery.test:402 »
User
TestTpchDistributed.tpch16:109->testDistributed:28->BaseTestQuery.test:402 »
User
TestTpchDistributed.tpch17:114->testDistributed:28->BaseTestQuery.test:402 »
User
TestTpchDistributed.tpch18:119->testDistributed:28->BaseTestQuery.test:402 »
User
TestTpchDistributed.tpch20:135->testDistributed:28->BaseTestQuery.test:402 »
User
TestTpchDistributed.tpch19_1:130->testDistributed:28->BaseTestQuery.test:402 »
User
TestTpchDistributedConcurrent.testConcurrentQueries:195 »
ConcurrentModification
Tests run: 2335, Failures: 4, Errors: 29, Skipped: 138
```
Otherwise option related changes LGTM
> Migrate OperatorFixture to use SystemOptionManager rather than mock
> -------------------------------------------------------------------
>
> Key: DRILL-5832
> URL: https://issues.apache.org/jira/browse/DRILL-5832
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.12.0
>
>
> The {{OperatorFixture}} provides structure for testing individual operators
> and other "sub-operator" bits of code. To do that, the framework provides
> mock network-free and server-free versions of the fragment context and
> operator context.
> As part of the mock, the {{OperatorFixture}} provides a mock version of the
> system option manager that provides a simple test-only implementation of an
> option set.
> With the recent major changes to the system option manager, this mock
> implementation has drifted out of sync with the system option manager. Rather
> than upgrading the mock implementation, this ticket asks to use the system
> option manager directly -- but configured for no ZK or file persistence of
> options.
> The key reason for this change is that the system option manager has
> implemented a sophisticated way to handle option defaults; it is better to
> leverage that than to provide a mock implementation.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
