[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201449#comment-16201449
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144195098
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/TopNBatch.java
---
@@ -95,7 +91,9 @@ public TopNBatch(TopN popConfig, FragmentContext context,
RecordBatch incoming)
super(popConfig, context);
this.incoming = incoming;
this.config = popConfig;
- batchPurgeThreshold =
context.getConfig().getInt(ExecConstants.BATCH_PURGE_THRESHOLD);
+ DrillConfig drillConfig = context.getConfig();
+ batchPurgeThreshold =
drillConfig.getInt(ExecConstants.BATCH_PURGE_THRESHOLD);
+ codegenDump =
drillConfig.getBoolean(CodeCompiler.ENABLE_SAVE_CODE_FOR_DEBUG);
--- End diff --
I will rename the option to drill.debug.codegen.TopN
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)