[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210148#comment-16210148
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144936994
--- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java ---
@@ -32,23 +32,50 @@
public class DirTestWatcher extends TestWatcher {
private String dirPath;
private File dir;
+ private boolean deleteDirAtEnd = true;
--- End diff --
Thanks for the Javadoc added previously. Perhaps add a section on how to
use this class. If I need a test directory, do I create an instance of this
class? Or, does JUnit do it for me? If done automagically, how do I get a copy
of the directory?
If this is explained in JUnit, perhaps just reference that information.
Even better would be a short example:
> To get a test directory:
```
// Do something here
File myDir = // do something
```
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
