[
https://issues.apache.org/jira/browse/DRILL-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211399#comment-16211399
]
ASF GitHub Bot commented on DRILL-5832:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/970#discussion_r145766019
--- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java
---
@@ -371,6 +373,16 @@ public static void testNoResult(String query,
Object... args) throws Exception {
testNoResult(1, query, args);
}
+ public static void alterSession(String key, Object value) throws
Exception {
--- End diff --
There is the setSessionOption method on line 487 that already does
something similar. Could we delete those methods and their usages in favor of
this one?
> Migrate OperatorFixture to use SystemOptionManager rather than mock
> -------------------------------------------------------------------
>
> Key: DRILL-5832
> URL: https://issues.apache.org/jira/browse/DRILL-5832
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.12.0
>
>
> The {{OperatorFixture}} provides structure for testing individual operators
> and other "sub-operator" bits of code. To do that, the framework provides
> mock network-free and server-free versions of the fragment context and
> operator context.
> As part of the mock, the {{OperatorFixture}} provides a mock version of the
> system option manager that provides a simple test-only implementation of an
> option set.
> With the recent major changes to the system option manager, this mock
> implementation has drifted out of sync with the system option manager. Rather
> than upgrading the mock implementation, this ticket asks to use the system
> option manager directly -- but configured for no ZK or file persistence of
> options.
> The key reason for this change is that the system option manager has
> implemented a sophisticated way to handle option defaults; it is better to
> leverage that than to provide a mock implementation.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
