[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211533#comment-16211533
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145790506
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -908,6 +908,15 @@ public void generateTestData(int count) {
}
<#else> <#-- type.width <= 8 -->
+ @Override
+ public void add(Object value) {
+ int index = accessor.getValueCount();
+ int valueCount = index + 1;
+ setValueCount(valueCount);
+
+ set(index, (${type.javaType}) value);
--- End diff --
All the issues with this make sense. I should have deleted this when I
switched to using the RowSet classes, but forgot too :). Removing this now.
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
