[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211693#comment-16211693
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145815670
--- Diff: exec/java-exec/src/test/resources/topN/one_key_sort.json ---
@@ -12,11 +12,11 @@
pop:"mock-scan",
url: "http://apache.org";,
entries:[
- {records: 10000000, types: [
+ {records: 100000, types: [
--- End diff --
The original test was checking to make sure the the Top N results returned
are ordered. It was never really necessary to generate that much data. The
benefit of reducing the amount of data generated is that the test runs faster.
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
