[ 
https://issues.apache.org/jira/browse/DRILL-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223454#comment-16223454
 ] 

ASF GitHub Bot commented on DRILL-5772:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/936#discussion_r147552950
  
    --- Diff: exec/java-exec/src/test/resources/saffron.properties ---
    @@ -0,0 +1,23 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to you under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +# http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +# This properties file is used by Apache Calcite to define allowed charset 
in string literals,
    +# which is by default ISO-8859-1.
    +# Current configuration allows parsing UTF-8 by default, i.e. queries that 
contain utf-8 string literal.
    +# To take affect this file should be present in classpath.
    +
    +saffron.default.charset=UTF-16LE
    +saffron.default.nationalcharset=UTF-16LE
    +saffron.default.collation.name=UTF-16LE$en_US
    --- End diff --
    
    We need separate test properties file to be included into classpath during 
tests execution. Tests run in exec module, while production properties reside 
in distribution module.



> Enable UTF-8 support in query string by default
> -----------------------------------------------
>
>                 Key: DRILL-5772
>                 URL: https://issues.apache.org/jira/browse/DRILL-5772
>             Project: Apache Drill
>          Issue Type: Task
>    Affects Versions: 1.11.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>              Labels: doc-impacting, ready-to-commit
>             Fix For: 1.12.0
>
>
> Now saffron.propertries file will be added into Drill conf directory which 
> will define default encoding used to parse query string.
> Content:
> {noformat}
> saffron.default.charset=UTF-16LE
> saffron.default.nationalcharset=UTF-16LE
> saffron.default.collation.name=UTF-16LE$en_US 
> {noformat}
> This information should be also documented, probably in 
> https://drill.apache.org/docs/data-type-conversion/.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to