[
https://issues.apache.org/jira/browse/DRILL-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306182#comment-16306182
]
Alex commented on DRILL-5772:
-----------------------------
The fix was tested, result: *PASSED*, no issues found. The following scenarios
were performed:
- Verify that UTF-16 encoding works properly by default after the drill was
installed (saffron.properties file is present in DRILL_HOME/conf/)
- Verify that saffron.properties file is responsible for the encoding type used
in drill queries (another charset was pre-setup in saffron.properties file)
- Verify that saffron properties pre-setup as system variables take priority
over the properties file (saffron properties were pre-setup in drill-env.sh
_export DRILL_JAVA_OPTS="$DRILL_JAVA_OPTS -Dsaffron.default.charset=ISO-8859-1
-Dsaffron.default.nationalcharset=ISO-8859-1
-Dsaffron.default.collation.name=ISO-8859-1\$en_US"_)
- Verify that the ISO-8859-1 encoding will take effect if a user removes the
saffron.properties file (saffron.properties was removed from DRILL_HOME/conf/
folder)
> Enable UTF-8 support in query string by default
> -----------------------------------------------
>
> Key: DRILL-5772
> URL: https://issues.apache.org/jira/browse/DRILL-5772
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.11.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Now saffron.propertries file will be added into Drill conf directory which
> will define default encoding used to parse query string.
> Content:
> {noformat}
> saffron.default.charset=UTF-16LE
> saffron.default.nationalcharset=UTF-16LE
> saffron.default.collation.name=UTF-16LE$en_US
> {noformat}
> Another option to override saffron properties is to set them as system
> options. This will take higher priority then saffron.properties file.
> Add to {{drill-env.sh}}:
> {noformat}
> DRILL_JAVA_OPTS="$DRILL_JAVA_OPTS -Dsaffron.default.charset=ISO-8859-1
> -Dsaffron.default.nationalcharset=ISO-8859-1
> -Dsaffron.default.collation.name=ISO-8859-1\$en_US"
> {noformat}
> NB!: the symbols $en_US must be preceded by \ character if one inserts the
> properties' row to drill-env.sh file, otherwise drill will stuck ->
> {{-Dsaffron.default.collation.name=ISO-8859-1\$en_US}}
> This information should be also documented, probably in
> https://drill.apache.org/docs/data-type-conversion/.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
