[
https://issues.apache.org/jira/browse/DRILL-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254819#comment-16254819
]
ASF GitHub Bot commented on DRILL-5584:
---------------------------------------
GitHub user superbstreak opened a pull request:
https://github.com/apache/drill/pull/1039
DRILL-5584: Add branding and versioning information for windows C++ C…
…lient.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/superbstreak/drill DRILL-5584
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1039
----
commit 7792fbfa11dc9a622217eb9a8f4644802e4e5e44
Author: Rob Wu <[email protected]>
Date: 2017-11-16T02:21:48Z
DRILL-5584: Add branding and versioning information for windows C++ Client.
----
> When Compiling Apache Drill C++ Client, versioning information are not
> present in the binary
> --------------------------------------------------------------------------------------------
>
> Key: DRILL-5584
> URL: https://issues.apache.org/jira/browse/DRILL-5584
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - C++
> Affects Versions: 1.10.0
> Reporter: Rob Wu
> Priority: Minor
>
> We should add support for generating an RC file containing the versioning
> information so this manual task can be automated.
> Current workaround:
> Compile the C++ Client DLL.
> Open the DLL and manually add a Version Resource with the following
> information:
> FILEVERSION 1,10,0,0
> PRODUCTVERSION 1,10,0,0
> CompanyName
> FileDescription Apache Drill C++ Client
> FileVersion 1.10.0.0
> InternalName drillClient.dll
> LegalCopyright Copyright (c) 2013-2017 The Apache Software
> Foundation
> OriginalFilename drillClient.dll
> ProductName Apache Drill C++ Client
> ProductVersion 1.10.0.0
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
