[
https://issues.apache.org/jira/browse/DRILL-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254820#comment-16254820
]
ASF GitHub Bot commented on DRILL-5584:
---------------------------------------
Github user superbstreak commented on a diff in the pull request:
https://github.com/apache/drill/pull/1039#discussion_r151329816
--- Diff: contrib/native/client/src/clientlib/env.h.in ---
@@ -30,6 +30,11 @@
#define GIT_SHA_PROP @GIT_SHA_PROP@
#define GIT_COMMIT_PROP @GIT_COMMIT_PROP@
+#define DRILL_LEGALCOPYRIGHT_STR "Copyright (c) 2013-2017 The Apache
Software Foundation\0"
--- End diff --
Reviewer, please make sure this is correct
> When Compiling Apache Drill C++ Client, versioning information are not
> present in the binary
> --------------------------------------------------------------------------------------------
>
> Key: DRILL-5584
> URL: https://issues.apache.org/jira/browse/DRILL-5584
> Project: Apache Drill
> Issue Type: Improvement
> Components: Client - C++
> Affects Versions: 1.10.0
> Reporter: Rob Wu
> Priority: Minor
>
> We should add support for generating an RC file containing the versioning
> information so this manual task can be automated.
> Current workaround:
> Compile the C++ Client DLL.
> Open the DLL and manually add a Version Resource with the following
> information:
> FILEVERSION 1,10,0,0
> PRODUCTVERSION 1,10,0,0
> CompanyName
> FileDescription Apache Drill C++ Client
> FileVersion 1.10.0.0
> InternalName drillClient.dll
> LegalCopyright Copyright (c) 2013-2017 The Apache Software
> Foundation
> OriginalFilename drillClient.dll
> ProductName Apache Drill C++ Client
> ProductVersion 1.10.0.0
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
