[
https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286540#comment-16286540
]
ASF GitHub Bot commented on DRILL-5730:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r156178698
--- Diff:
common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
@@ -45,13 +45,11 @@
private final ImmutableList<String> startupArguments;
- public static final boolean ON_OSX =
System.getProperty("os.name").contains("OS X");
-
@SuppressWarnings("restriction")
private static final long MAX_DIRECT_MEMORY =
sun.misc.VM.maxDirectMemory();
@VisibleForTesting
- public DrillConfig(Config config, boolean enableServerConfigs) {
+ public DrillConfig(Config config) {
--- End diff --
I'm going to guess that the same `DrillConfig` is used (sadly) in the Drill
client and Drill server. (Sadly because it is odd for a client application to
need to provide a config file in order to connect to a Drill server. Just adds
unnecessary complexity, especially for third-party apps that happen to include
a Drill JDBC driver. Sigh...)
In the client mode, we don't want to load all the internal server configs
because we'll never use them.
Not sure if this is actually how this flag has been used (maybe it was
added, then forgotten.) But, it is worth checking the client code to see if it
was ever used.
> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
> Key: DRILL-5730
> URL: https://issues.apache.org/jira/browse/DRILL-5730
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests:
> TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
> TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but
> was:<FAILED>
> Tests in error:
> TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR:
> URISyntaxExcepti...
> TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR:
> URISyn...
> TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth »
> UserRemote
> TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344
> » Rpc
> TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 »
> Rpc o...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
