[
https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286546#comment-16286546
]
ASF GitHub Bot commented on DRILL-5730:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r156186386
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/BaseOperatorContext.java
---
@@ -39,27 +39,29 @@
* version of the operator context and the full production-time context
* that includes network services.
*/
-
public abstract class BaseOperatorContext implements OperatorContext {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(BaseOperatorContext.class);
- protected final FragmentContextInterface context;
+ protected final FragmentContext context;
protected final BufferAllocator allocator;
protected final PhysicalOperator popConfig;
protected final BufferManager manager;
+ protected OperatorStatReceiver statsWriter;
private DrillFileSystem fs;
private ControlsInjector injector;
- public BaseOperatorContext(FragmentContextInterface context,
BufferAllocator allocator,
- PhysicalOperator popConfig) {
+ public BaseOperatorContext(FragmentContext context, BufferAllocator
allocator,
+ PhysicalOperator popConfig,
+ OperatorStatReceiver stats) {
this.context = context;
this.allocator = allocator;
this.popConfig = popConfig;
this.manager = new BufferManagerImpl(allocator);
+ this.statsWriter = stats;
--- End diff --
This member was removed in a recent commit. Since the test and production
versions need different implementation, the derived classes manage the operator
stats.
> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
> Key: DRILL-5730
> URL: https://issues.apache.org/jira/browse/DRILL-5730
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests:
> TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
> TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but
> was:<FAILED>
> Tests in error:
> TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR:
> URISyntaxExcepti...
> TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR:
> URISyn...
> TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth »
> UserRemote
> TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344
> » Rpc
> TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 »
> Rpc o...
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
