[ 
https://issues.apache.org/jira/browse/DRILL-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299331#comment-16299331
 ] 

ASF GitHub Bot commented on DRILL-3993:
---------------------------------------

Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1066#discussion_r158120135
  
    --- Diff: 
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseSchemaFactory.java
 ---
    @@ -72,7 +72,16 @@ public AbstractSchema getSubSchema(String name) {
         @Override
         public Table getTable(String name) {
           HBaseScanSpec scanSpec = new HBaseScanSpec(name);
    -      return new DrillHBaseTable(schemaName, plugin, scanSpec);
    +      try {
    +        return new DrillHBaseTable(schemaName, plugin, scanSpec);
    +      } catch (Exception e) {
    +        // Calcite firstly is looking for a table in the default schema, 
if a table was not found,
    --- End diff --
    
    'is looking for' and 'is looking in' seems to be saying Calcite IS working 
in this line of code, but I think you meant that for the new version calcite, 
it 'looks for' something... so would like to get some rephrase here.


> Rebase Drill on Calcite master branch
> -------------------------------------
>
>                 Key: DRILL-3993
>                 URL: https://issues.apache.org/jira/browse/DRILL-3993
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.2.0
>            Reporter: Sudheesh Katkam
>            Assignee: Roman Kulyk
>
> Calcite keeps moving, and now we need to catch up to Calcite 1.5, and ensure 
> there are no regressions.
> Also, how do we resolve this 'catching up' issue in the long term?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to