[
https://issues.apache.org/jira/browse/DRILL-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300020#comment-16300020
]
ASF GitHub Bot commented on DRILL-3993:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1066#discussion_r158258149
--- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
@@ -75,6 +72,26 @@
implementationFiles: [
"parserImpls.ftl"
]
+
+ # List of methods for parsing extensions to "CREATE [OR REPLACE]" calls.
+ # Each must accept arguments "(SqlParserPos pos, boolean replace)".
+ createStatementParserMethods: [
--- End diff --
Calcites `Parser.jj` uses these lists to extend existing functionality when
desired methods specified inside it. If we did not specify these lists, java
class `Parser.java` could not be generated and build would fail with the error:
```
[ERROR] Failed to execute goal
org.apache.drill.tools:drill-fmpp-maven-plugin:1.12.0-SNAPSHOT:generate
(generate-fmpp) on project drill-java-exec: FMPP processing session failed.
[ERROR] Caused by: freemarker.core.InvalidReferenceException: The following
has evaluated to null or missing:
[ERROR] ==> parser.createStatementParserMethods [in template "Parser.jj"
at line 881, column 6]
```
> Rebase Drill on Calcite master branch
> -------------------------------------
>
> Key: DRILL-3993
> URL: https://issues.apache.org/jira/browse/DRILL-3993
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.2.0
> Reporter: Sudheesh Katkam
> Assignee: Roman Kulyk
>
> Calcite keeps moving, and now we need to catch up to Calcite 1.5, and ensure
> there are no regressions.
> Also, how do we resolve this 'catching up' issue in the long term?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
