[
https://issues.apache.org/jira/browse/DRILL-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302678#comment-16302678
]
ASF GitHub Bot commented on DRILL-5851:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593969
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -65,11 +65,18 @@ protected boolean prefetchFirstBatchFromBothSides() {
return false;
}
- if (leftUpstream == IterOutcome.NONE && rightUpstream ==
IterOutcome.NONE) {
+ if (checkForEarlyFinish()) {
state = BatchState.DONE;
return false;
}
return true;
}
+
+ /*
+ * Checks for the operator specific early terminal condition.
+ * @return true if the further processing can stop.
+ * false if the further processing is needed.
+ */
+ protected abstract boolean checkForEarlyFinish();
--- End diff --
This is abstract, But, all implementations are identical. Can't we just
move the implementation here?
> Empty table during a join operation with a non empty table produces cast
> exception
> -----------------------------------------------------------------------------------
>
> Key: DRILL-5851
> URL: https://issues.apache.org/jira/browse/DRILL-5851
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.11.0
> Reporter: Hanumath Rao Maduri
> Assignee: Hanumath Rao Maduri
>
> Hash Join operation on tables with one table empty and the other non empty
> throws an exception
> {code}
> Error: SYSTEM ERROR: DrillRuntimeException: Join only supports implicit casts
> between 1. Numeric data
> 2. Varchar, Varbinary data 3. Date, Timestamp data Left type: VARCHAR, Right
> type: INT. Add explicit casts to avoid this error
> {code}
> Here is an example query with which it is reproducible.
> {code}
> select * from cp.`sample-data/nation.parquet` nation left outer join
> dfs.tmp.`2.csv` as two on two.a = nation.`N_COMMENT`;
> {code}
> the contents of 2.csv is empty (i.e not even header info).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
