[jira] [Commented] (DRILL-5851) Empty table during a join operation with a non empty table produces cast exception

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302682#comment-16302682
 ] 

ASF GitHub Bot commented on DRILL-5851:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1059#discussion_r158593930
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
 ---
    @@ -333,4 +341,74 @@ public void testNlJoinWithLargeRightInputSuccess() 
throws Exception {
           test(RESET_JOIN_OPTIMIZATION);
         }
       }
    +
    +  private void buildFile(String fileName, String[] data, File testDir) 
throws IOException {
    +    try(PrintWriter out = new PrintWriter(new FileWriter(new File(testDir, 
fileName)))) {
    +      for (String line : data) {
    +        out.println(line);
    +      }
    +    }
    +  }
    +
    +  @Test
    +  public void testNestedLeftJoinWithEmptyTable() throws Exception {
    +    setSessionOption("planner.enable_join_optimization", false);
    +    setSessionOption("planner.enable_nljoin_for_scalar_only", false);
    +    setSessionOption("planner.enable_hashjoin", false);
    +    setSessionOption("planner.enable_mergejoin", false);
    +    try (ClusterFixture cluster = 
ClusterFixture.builder(dirTestWatcher).build();
    +      ClientFixture client = cluster.clientFixture()) {
    +      File testDir = dirTestWatcher.getRootDir();
    +      buildFile("dept.json", new String[0], testDir);
    +      QueryBuilder query = client.queryBuilder().sql("select * from 
cp.`employee.json` emp left outer join dfs.`dept.json` as dept on dept.manager 
= emp.`last_name`");
    +      assert(query.run().recordCount() == 1155);
    +    } catch (RuntimeException ex) {
    +      fail (ex.getMessage());
    +    } finally {
    +      resetSessionOption("planner.enable_join_optimization");
    +      resetSessionOption("planner.enable_nljoin_for_scalar_only");
    +      resetSessionOption("planner.enable_hashjoin");
    +      resetSessionOption("planner.enable_mergejoin");
    +    }
    +  }
    +
    +  @Test
    +  public void testNestedInnerJoinWithEmptyTable() throws Exception {
    +    setSessionOption("planner.enable_nljoin_for_scalar_only", false);
    --- End diff --
    
    Same comment as above: duplicate code. Here we see the problem with copies. 
This test, and the next one, set three options. The prior one sets four 
options. Which is right?


> Empty table during a join operation with a non empty table produces cast 
> exception 
> -----------------------------------------------------------------------------------
>
>                 Key: DRILL-5851
>                 URL: https://issues.apache.org/jira/browse/DRILL-5851
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Relational Operators
>    Affects Versions: 1.11.0
>            Reporter: Hanumath Rao Maduri
>            Assignee: Hanumath Rao Maduri
>
> Hash Join operation on tables with one table empty and the other non empty 
> throws an exception 
> {code} 
> Error: SYSTEM ERROR: DrillRuntimeException: Join only supports implicit casts 
> between 1. Numeric data
>  2. Varchar, Varbinary data 3. Date, Timestamp data Left type: VARCHAR, Right 
> type: INT. Add explicit casts to avoid this error
> {code}
> Here is an example query with which it is reproducible.
> {code}
> select * from cp.`sample-data/nation.parquet` nation left outer join 
> dfs.tmp.`2.csv` as two on two.a = nation.`N_COMMENT`;
> {code}
> the contents of 2.csv is empty (i.e not even header info).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)