[
https://issues.apache.org/jira/browse/DRILL-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361714#comment-16361714
]
ASF GitHub Bot commented on DRILL-6148:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1120#discussion_r167743599
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
---
@@ -59,6 +59,7 @@ public static void setup() throws Exception {
ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
.configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 1) //
Unmanaged
.configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 1)
// Unmanaged
+ .configProperty(ExecConstants.EXTERNAL_SORT_MAX_MEMORY, 10 * 1024
* 1024) //use less memory for sorting.
--- End diff --
The need to set this property suggest something is wrong with the next one.
We set max query memory per node to 60 MB. Then, the
`MemoryAllocationUtilitites` is supposed to divide that up. If you have to
override that, then something is amiss. We should track down that problem.
A good place to start is to turn on logging for this test (using the log
fixture.) The sort will dump its configured memory. If it is still 2 GB, then
debug the memory allocation utilities.
Perhaps it is as simple as using the wrong option below...
> TestSortSpillWithException is sometimes failing.
> ------------------------------------------------
>
> Key: DRILL-6148
> URL: https://issues.apache.org/jira/browse/DRILL-6148
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.12.0
> Reporter: Hanumath Rao Maduri
> Assignee: Hanumath Rao Maduri
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.13.0
>
>
> TestSortSpillWithException#testSpillLeakManaged is sometimes failing. However
> for some reason this is being observed only in one of my branch.
> TestSpillLeakManaged tests for leak when an exception is thrown during the
> spilling of the rows in ExternalSort. In the test failure case it happens
> that ExternalSort is able to sort the data with the given memory and not
> spill at all. Hence the injection interruption path is not hit at all and
> hence no exception is thrown.
> The test case should use drill.exec.sort.external.mem_limit to force it to
> use as less memory as possible so as to test the case.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
