ASF GitHub Bot commented on DRILL-6148:

Github user HanumathRao commented on a diff in the pull request:

    --- Diff: 
    @@ -59,6 +59,7 @@ public static void setup() throws Exception {
         ClusterFixtureBuilder builder = ClusterFixture.builder(dirTestWatcher)
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 1) // 
             .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 1) 
// Unmanaged
    +        .configProperty(ExecConstants.EXTERNAL_SORT_MAX_MEMORY, 10 * 1024 
* 1024) //use less memory for sorting.
    --- End diff --
    @paul-rogers  Thank you for the review. In this case, the memory configured 
per node is 60MB and the maxParallelization is set to 1. The min buffered op 
memory is 40MB by default.
       * Minimum memory allocated to each buffered operator instance.
       * <p/>
       * DEFAULT: 40 MB
    In my branch (which has got other changes also) 40MB is being correctly set 
for the sort to use. However, this memory is sufficient for the concerned query 
to not to spill the data to disk and it is executing fine without triggering 
the exception mechanism.
    I tried to set max_per_node memory to 10MB but even after setting the 
memorycomputation utilities will only set sort memory to 40MB. Hence it is of 
no use in this case.
    Therefore, I have used this option so that this test will consistently 
pass. Please let me know if I am missing anything here.

> TestSortSpillWithException is sometimes failing.
> ------------------------------------------------
>                 Key: DRILL-6148
>                 URL: https://issues.apache.org/jira/browse/DRILL-6148
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build &amp; Test
>    Affects Versions: 1.12.0
>            Reporter: Hanumath Rao Maduri
>            Assignee: Hanumath Rao Maduri
>            Priority: Minor
>              Labels: ready-to-commit
>             Fix For: 1.13.0
> TestSortSpillWithException#testSpillLeakManaged is sometimes failing. However 
> for some reason this is being observed only in one of my branch. 
> TestSpillLeakManaged tests for leak when an exception is thrown during the 
> spilling of the rows in ExternalSort. In the test failure case it happens 
> that ExternalSort is able to sort the data with the given memory and not 
> spill at all. Hence the injection interruption path is not hit at all and 
> hence no exception is thrown.
> The test case should use drill.exec.sort.external.mem_limit to force it to 
> use as less memory as possible so as to test the case.

This message was sent by Atlassian JIRA

Reply via email to