[ 
https://issues.apache.org/jira/browse/DRILL-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388383#comment-16388383
 ] 

ASF GitHub Bot commented on DRILL-4120:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1138#discussion_r172620291
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/avro/AvroDrillTable.java
 ---
    @@ -58,16 +65,31 @@ public AvroDrillTable(String storageEngineName,
     
       @Override
       public RelDataType getRowType(RelDataTypeFactory typeFactory) {
    -    List<RelDataType> typeList = Lists.newArrayList();
    -    List<String> fieldNameList = Lists.newArrayList();
    +    // ExtendableRelDataTypeHolder is reused to preserve previously added 
implicit columns
    +    if (holder == null) {
    +      List<RelDataType> typeList = Lists.newArrayList();
    +      List<String> fieldNameList = Lists.newArrayList();
     
    -    Schema schema = reader.getSchema();
    -    for (Field field : schema.getFields()) {
    -      fieldNameList.add(field.name());
    -      typeList.add(getNullableRelDataTypeFromAvroType(typeFactory, 
field.schema()));
    +      // adds partition columns to RowType
    +      List<String> partitions = 
ColumnExplorer.getPartitions(((FormatSelection) getSelection()).getSelection(), 
schemaConfig);
    --- End diff --
    
    1. Yes, it is safe, since we are using the same `FormatSelection` instance 
as we passed to the parent constructor.
    2. Thanks, done.


> dir0 does not work when the directory structure contains Avro files
> -------------------------------------------------------------------
>
>                 Key: DRILL-4120
>                 URL: https://issues.apache.org/jira/browse/DRILL-4120
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.3.0
>            Reporter: Stefán Baxter
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.13.0
>
>         Attachments: 
> 0001-DRILL-4120-Support-reading-directories-having-avro-f.patch
>
>
> Any select statment containing dirN fails if the target directory structure 
> contains Avro files.
> Steps to test:
> 1. create a simple directory structure
> 2. copy an avro file into each directory
> 3. execute a query containing dir0
> outcome:
> Error: VALIDATION ERROR: From line 1, column 117 to line 1, column 120: 
> Column 'dir0' not found in any table



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to