[
https://issues.apache.org/jira/browse/DRILL-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390560#comment-16390560
]
ASF GitHub Bot commented on DRILL-6210:
---------------------------------------
Github user Ben-Zvi commented on the issue:
https://github.com/apache/drill/pull/1150
@paul-rogers this change also affects the new code (PR#1125) from @ppadma ;
the required changes are proposed below; are these correct ? Can you rebase (
#1125 should be committed soon), fix, squash, etc. ?
```
---
a/exec/java-exec/src/test/java/org/apache/drill/exec/record/TestRecordBatchSizer.java
+++
b/exec/java-exec/src/test/java/org/apache/drill/exec/record/TestRecordBatchSizer.java
@@ -32,7 +32,7 @@ import org.apache.drill.test.SubOperatorTest;
import org.apache.drill.test.rowSet.RowSet;
import org.apache.drill.test.rowSet.RowSet.SingleRowSet;
import org.apache.drill.test.rowSet.RowSetBuilder;
-import org.apache.drill.test.rowSet.SchemaBuilder;
+import org.apache.drill.test.rowSet.schema.SchemaBuilder;
import org.junit.Test;
public class TestRecordBatchSizer extends SubOperatorTest {
@@ -506,7 +506,7 @@ public class TestRecordBatchSizer extends
SubOperatorTest {
.addMap("map")
.add("key", MinorType.INT)
.add("value", MinorType.VARCHAR)
- .buildMap()
+ .resumeSchema()
.build();
RowSetBuilder builder = fixture.rowSetBuilder(schema);
@@ -589,7 +589,7 @@ public class TestRecordBatchSizer extends
SubOperatorTest {
BatchSchema schema = new SchemaBuilder().addMapArray("map").
add("key", MinorType.INT).
add("value", MinorType.VARCHAR).
- buildMap().build();
+ resumeSchema().build();
RowSetBuilder builder = fixture.rowSetBuilder(schema);
@@ -694,8 +694,8 @@ public class TestRecordBatchSizer extends
SubOperatorTest {
.addMap("childMap")
.add("childKey", MinorType.INT)
.add("childValue", MinorType.VARCHAR)
- .buildMap()
- .buildMap()
+ .resumeMap()
+ .resumeSchema()
.build();
RowSetBuilder builder = fixture.rowSetBuilder(schema);
```
> Enhance the test schema builder for remaining types
> ---------------------------------------------------
>
> Key: DRILL-6210
> URL: https://issues.apache.org/jira/browse/DRILL-6210
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> The result set loader project enhanced the schema builder used in tests to
> handle Drill's complex types: maps, unions, lists and repeated lists. The
> schema builder previously only handled maps.
> This ticket describes the addition of just this one part of the result set
> loader.
> Also adds a run-time schema improvement: functions to create arrays when
> testing rather than writing out the {{new String[] \{"foo", "bar"\}}} syntax.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
