ASF GitHub Bot commented on DRILL-6210:

Github user paul-rogers commented on the issue:

    @Ben-Zvi, the changes look right. Old style was to have a "buildFoo" method 
for the nested structure "foo". The new style is to have a "resumeBar" method 
for the outer structure "bar".
    If you have trouble, an alternative is to commit @ppadma's PR. Then I can 
immediately rebase and make the required fixes to her tests.

> Enhance the test schema builder for remaining types
> ---------------------------------------------------
>                 Key: DRILL-6210
>                 URL: https://issues.apache.org/jira/browse/DRILL-6210
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.14.0
> The result set loader project enhanced the schema builder used in tests to 
> handle Drill's complex types: maps, unions, lists and repeated lists. The 
> schema builder previously only handled maps.
> This ticket describes the addition of just this one part of the result set 
> loader.
> Also adds a run-time schema improvement: functions to create arrays when 
> testing rather than writing out the {{new String[] \{"foo", "bar"\}}} syntax.

This message was sent by Atlassian JIRA

Reply via email to