[
https://issues.apache.org/jira/browse/DRILL-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419420#comment-16419420
]
ASF GitHub Bot commented on DRILL-6202:
---------------------------------------
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/1144
To be honest, I don't know. There are too many paths available to write to
direct memory, some which were developed over time and so not all vector code
may be using them.
Ideally, every bit of code should go thru DrillBuf which wraps a UDLE
(UnsafeDirectLittleEndian). UDLE has one level of bounds check (which I feel is
necessary) and uses PlatformDependent directly.
Vector set safe methods provides vector level bounds checking and the
vector set methods bypass bounds checking. ResultSetLoader methods provide
guarantees that may make the set safe methods redundant.
Our goal should be to not depend on the set safe methods except for
debugging.
What exactly are you thinking of when proposing using PlatformDependent
directly.
> Deprecate usage of IndexOutOfBoundsException to re-alloc vectors
> ----------------------------------------------------------------
>
> Key: DRILL-6202
> URL: https://issues.apache.org/jira/browse/DRILL-6202
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Major
> Fix For: 1.14.0
>
>
> As bounds checking may be enabled or disabled, using
> IndexOutOfBoundsException to resize vectors is unreliable. It works only when
> bounds checking is enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
