[
https://issues.apache.org/jira/browse/DRILL-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423360#comment-16423360
]
ASF GitHub Bot commented on DRILL-6202:
---------------------------------------
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1144
It is not clear why get/set Byte/Char/Short/Int/Long/Float/Double do not
delegate to UDLE, while get/set Bytes delegates to UDLE and relies on netty
'AbstractByteBuf` for bounds checking. IMO, it will be good to have the
behavior consistent for all methods.
In many cases including `VariableLengthVectors`, there is no need to rely
on UDLE boundary checking as a caller already provides or can provide a
guarantee that an index is within a buffer boundaries. In those cases, boundary
check becomes an extra cost. IMO, it will be good to have a consistent behavior
with ability to enable bounds checking for debugging.
> Deprecate usage of IndexOutOfBoundsException to re-alloc vectors
> ----------------------------------------------------------------
>
> Key: DRILL-6202
> URL: https://issues.apache.org/jira/browse/DRILL-6202
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Major
> Fix For: 1.14.0
>
>
> As bounds checking may be enabled or disabled, using
> IndexOutOfBoundsException to resize vectors is unreliable. It works only when
> bounds checking is enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
