[ 
https://issues.apache.org/jira/browse/DRILL-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436467#comment-16436467
 ] 

ASF GitHub Bot commented on DRILL-6320:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1207#discussion_r181248921
  
    --- Diff: pom.xml ---
    @@ -198,6 +200,78 @@
     
       <build>
         <plugins>
    +      <plugin>
    +        <groupId>org.apache.rat</groupId>
    +        <artifactId>apache-rat-plugin</artifactId>
    +        <version>0.12</version>
    +        <executions>
    +          <execution>
    +            <id>rat-checks</id>
    +            <phase>validate</phase>
    +            <goals>
    +              <goal>check</goal>
    +            </goals>
    +          </execution>
    +        </executions>
    +        <configuration>
    +          <skip>${rat.skip}</skip>  <!-- DRILL-6320 License checks are 
intentionally skipped by default for development -->
    --- End diff --
    
    I originally tried `<skip>true</skip>` . However, this does not allow the 
skip to be overridden when the `-Drat.skip=false` argument is provided. It 
seems the only way to have an overridable default is to explicitly define a 
property with the default value. 


> Don't Allow Javadoc comments for license headers
> ------------------------------------------------
>
>                 Key: DRILL-6320
>                 URL: https://issues.apache.org/jira/browse/DRILL-6320
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Currently some license headers are in a javadoc comment instead of a normal 
> comment. This is not good since we don't want to include spurious license 
> headers in java docs when we publish them. The fix would be to change the rat 
> plugin configuration to not allow java doc comments.
>  
> *For documentation*
> Min required maven version has changed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to