[ 
https://issues.apache.org/jira/browse/DRILL-6320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436468#comment-16436468
 ] 

ASF GitHub Bot commented on DRILL-6320:
---------------------------------------

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1207#discussion_r181248949
  
    --- Diff: pom.xml ---
    @@ -375,12 +449,12 @@
               </gitDescribe>
             </configuration>
           </plugin>
    -
           <plugin>
             <groupId>com.mycila</groupId>
             <artifactId>license-maven-plugin</artifactId>
             <version>3.0</version>
             <configuration>
    +          <skip>${license.skip}</skip> <!-- DRILL-6320 License checks are 
intentionally skipped by default for development -->
    --- End diff --
    
    see comment above.


> Don't Allow Javadoc comments for license headers
> ------------------------------------------------
>
>                 Key: DRILL-6320
>                 URL: https://issues.apache.org/jira/browse/DRILL-6320
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Currently some license headers are in a javadoc comment instead of a normal 
> comment. This is not good since we don't want to include spurious license 
> headers in java docs when we publish them. The fix would be to change the rat 
> plugin configuration to not allow java doc comments.
>  
> *For documentation*
> Min required maven version has changed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to