[ 
https://issues.apache.org/jira/browse/DRILL-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443296#comment-16443296
 ] 

ASF GitHub Bot commented on DRILL-6334:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1213#discussion_r182590683
  
    --- Diff: 
exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java
 ---
    @@ -37,6 +37,7 @@ public void testSettingSameValueCount()
       {
         try (RootAllocator allocator = new RootAllocator(10_000_000)) {
           final MaterializedField field = 
MaterializedField.create("stringCol", 
Types.required(TypeProtos.MinorType.VARCHAR));
    +      @SuppressWarnings("resource")
    --- End diff --
    
    @paul-rogers Thank you for making the changes. Can you please double check 
whether it is necessary to suppress the warning here. It is confusing why the 
same warning suppression is removed in some places and added in others.


> Code cleanup
> ------------
>
>                 Key: DRILL-6334
>                 URL: https://issues.apache.org/jira/browse/DRILL-6334
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Trivial
>              Labels: ready-to-commit
>             Fix For: 1.14.0
>
>
> Minor cleanup of a few files. Done as a separate PR to allow easier review.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to